Pascal Getreuer 73e2ef486a [Bug][Core] Fix for Flow Tap: fix handling of distinct taps and timer updates. (#25175) ... * Flow Tap bug fix. As reported by @amarz45 and @mwpardue, there is a bug where if two tap-hold keys are pressed in distinct taps back to back, then Flow Tap is not applied on the second tap-hold key, but it should be. In a related bug reported by @NikGovorov, if a tap-hold key is held followed by a tap of a tap-hold key, then Flow Tap updates its timer on the release of the held tap-hold key, but it should be ignored. The problem common to both these bugs is that I incorrectly assumed `tapping_key` is cleared to noevent once it is released, when actually `tapping_key` is still maintained for `TAPPING_TERM` ms after release (for Quick Tap). This commit fixes that. Thanks to @amarz45, @mwpardue, and @NikGovorov for reporting! Details: * Logic for converting the current tap-hold event to a tap is extracted to `flow_tap_key_if_within_term()`, which is now invoked also in the post-release "interfered with other tap key" case. This fixes the distinct taps bug. * The Flow Tap timer is now updated at the beginning of each call to `process_record()`, provided that there is no unsettled tap-hold key at that time and that the record is not for a mod or layer switch key. By moving this update logic to `process_record()`, it is conceptually simpler and more robust. * Unit tests extended to cover the reported scenarios. * Fix formatting. * Revision to fix @NikGovorov's scenario. The issue is that when another key is pressed while a layer-tap hasn't been settled yet, the `prev_keycode` remembers the keycode from before the layer switched. This can then enable Flow Tap for the following key when it shouldn't, or vice versa. Thanks to @NikGovorov for reporting! This commit revises Flow Tap in the following ways: * The previous key and timer are both updated from `process_record()`. This is slightly later in the sequence of processing than before, and by this point, a just-settled layer-tap should have taken effect so that the keycode from the correct layer is remembered. * The Flow Tap previous key and timer are updated now also on key release events, except for releases of modifiers and held layer switches. * The Flow Tap previous key and timer are now updated together, for simplicity. This makes the logic easier to think about. * A few additional unit tests, including @NikGovorov's scenario as "layer_tap_ignored_with_disabled_key_complex."		2025-04-22 09:59:49 +02:00
..
audio	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
backlight	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
bootmagic	Removal of bootmagic lite terminology (#22979)	2024-02-17 12:27:34 +00:00
connection	Implement connection keycode logic (#25176)	2025-04-21 22:27:56 +01:00
debounce	Consolidate timer_elapsed implementations (#24830)	2025-01-19 17:07:11 +00:00
encoder/tests	Rename encoder pins defines (#24003)	2024-07-03 17:18:27 +10:00
keymap_extras	[CI] Regenerate Files (#24772)	2025-01-01 02:22:28 +00:00
led_matrix	Allow for disabling EEPROM subsystem entirely. (#25173)	2025-04-19 20:20:00 +01:00
logging	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
midi	Unify MIDI note calculation with the audio feature's algorithm (#21588)	2023-07-27 16:14:34 -07:00
nvm	Implement connection keycode logic (#25176)	2025-04-21 22:27:56 +01:00
os_detection/tests	Merge remote-tracking branch 'origin/master' into develop	2025-01-29 19:28:06 +00:00
painter	Created SH1107 driver for quantum painter (#24724)	2025-02-17 08:41:07 +11:00
pointing_device	[chore]: move and rename mouse/scroll min/max defines (#25141)	2025-04-13 18:36:13 +02:00
process_keycode	Implement connection keycode logic (#25176)	2025-04-21 22:27:56 +01:00
rgb_matrix	Allow for disabling EEPROM subsystem entirely. (#25173)	2025-04-19 20:20:00 +01:00
rgblight	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
send_string	Consolidate send_string implementations. (#24817)	2025-01-21 08:24:39 +11:00
sequencer	Consolidate timer_elapsed implementations (#24830)	2025-01-19 17:07:11 +00:00
split_common	Add EOL to non-keyboard files (#24990)	2025-03-06 23:17:51 +00:00
unicode	Allow for disabling EEPROM subsystem entirely. (#25173)	2025-04-19 20:20:00 +01:00
wear_leveling	Add EOL to non-keyboard files (#24990)	2025-03-06 23:17:51 +00:00
action.c	[Bug][Core] Fix for Flow Tap: fix handling of distinct taps and timer updates. (#25175)	2025-04-22 09:59:49 +02:00
action.h	[Core] Flow Tap tap-hold option to disable HRMs during fast typing (#25125)	2025-04-14 09:46:24 -07:00
action_code.h	Relocate various modifier defines (#18638)	2023-03-10 18:27:29 -08:00
action_layer.c	Remove use of keymap.h (#20004)	2023-03-27 20:08:17 +01:00
action_layer.h	process_keycode: remove direct quantum.h includes (#21486)	2023-07-11 17:07:24 +10:00
action_tapping.c	[Bug][Core] Fix for Flow Tap: fix handling of distinct taps and timer updates. (#25175)	2025-04-22 09:59:49 +02:00
action_tapping.h	[Bug][Core] Fix for Flow Tap: fix handling of distinct taps and timer updates. (#25175)	2025-04-22 09:59:49 +02:00
action_util.c	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
action_util.h	Separate 6KRO and NKRO report structs (#22267)	2023-10-23 15:43:46 +11:00
basic_profiling.h	Remove arm_atsam platform (#24337)	2024-09-02 03:48:17 +01:00
bits.h	Fix path typo related RP2040 (#25069)	2025-03-28 21:03:59 +11:00
bitwise.c	Format code according to conventions (#16322)	2022-02-12 18:29:31 +00:00
bitwise.h	Migrate some tmk_core files to quantum (#11791)	2021-02-07 23:16:15 +00:00
caps_word.c	Reduce includes for caps_word header (#18948)	2022-11-03 23:42:58 +00:00
caps_word.h	Reduce includes for caps_word header (#18948)	2022-11-03 23:42:58 +00:00
color.c	Rename RGB and HSV structs (#24471)	2024-10-12 00:10:02 +01:00
color.h	Rename RGB and HSV structs (#24471)	2024-10-12 00:10:02 +01:00
command.c	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
command.h	Remove legacy keycode use from command (#18002)	2022-08-12 03:03:36 +01:00
crc.c	Reduce includes for crc header (#18947)	2022-11-03 21:36:58 +00:00
crc.h	Reduce includes for crc header (#18947)	2022-11-03 21:36:58 +00:00
debounce.h	debounce: remove direct quantum.h includes (#21480)	2023-07-09 02:05:20 +01:00
deferred_exec.c	[Bugfix] Manipulate deferred executor slot only if tokens match (#22722)	2023-12-21 09:32:19 +11:00
deferred_exec.h	Advanced deferred_exec for core-side code. (#15579)	2022-01-10 18:26:46 +00:00
digitizer.c	Digitizer feature improvements (#19034)	2022-11-12 23:28:11 +00:00
digitizer.h	Update Doxygen comments for some headers (#20194)	2023-03-22 14:32:49 +11:00
dip_switch.c	Fix missing wait.h include in Dip Switch Map (#24863)	2025-01-25 03:11:38 +00:00
dip_switch.h	Keymap introspection for Dip Switches (#22543)	2023-12-11 23:06:18 +00:00
dynamic_keymap.c	Allow for disabling EEPROM subsystem entirely. (#25173)	2025-04-19 20:20:00 +01:00
dynamic_keymap.h	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
eeconfig.c	Implement connection keycode logic (#25176)	2025-04-21 22:27:56 +01:00
eeconfig.h	Implement connection keycode logic (#25176)	2025-04-21 22:27:56 +01:00
encoder.c	Normalise mouse keycodes (#23975)	2024-07-03 18:35:54 +10:00
encoder.h	Rename encoder pins defines (#24003)	2024-07-03 17:18:27 +10:00
haptic.c	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
haptic.h	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
joystick.c	Joystick: add support for 8-way hat switch (#24515)	2024-11-09 14:10:10 -08:00
joystick.h	Joystick: add support for 8-way hat switch (#24515)	2024-11-09 14:10:10 -08:00
keyboard.c	Implement connection keycode logic (#25176)	2025-04-21 22:27:56 +01:00
keyboard.h	Keymap introspection for Dip Switches (#22543)	2023-12-11 23:06:18 +00:00
keycode.h	Normalise mouse keycodes (#23975)	2024-07-03 18:35:54 +10:00
keycode_config.c	Begin removal of bootmagic lite terminology (#22970)	2024-01-28 22:51:58 +00:00
keycode_config.h	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
keycode_string.c	[Core] get_keycode_string(): function to format keycodes as strings, for more readable debug logging. (#24787)	2025-03-19 20:45:56 +01:00
keycode_string.h	[Core] get_keycode_string(): function to format keycodes as strings, for more readable debug logging. (#24787)	2025-03-19 20:45:56 +01:00
keycodes.h	Community modules (#24848)	2025-02-26 22:25:41 +11:00
keymap_common.c	Keymap introspection for Dip Switches (#22543)	2023-12-11 23:06:18 +00:00
keymap_common.h	Remove use of keymap.h (#20004)	2023-03-27 20:08:17 +01:00
keymap_introspection.c	Community modules (#24848)	2025-02-26 22:25:41 +11:00
keymap_introspection.h	Add support for key override introspection. (#24120)	2024-07-16 09:22:17 +10:00
layer_lock.c	Review fixes for layer lock feature (#24627)	2024-11-21 13:02:49 +00:00
layer_lock.h	Review fixes for layer lock feature (#24627)	2024-11-21 13:02:49 +00:00
leader.c	Add leader_add_user callback (#24266)	2025-01-01 23:12:58 -08:00
leader.h	Add leader_add_user callback (#24266)	2025-01-01 23:12:58 -08:00
led.c	Remove deprecated led_set_user (#23979)	2024-06-22 09:10:58 +01:00
led.h	Remove deprecated led_set_user (#23979)	2024-06-22 09:10:58 +01:00
led_tables.c	Remove unused LED_BREATHING_TABLE	2020-03-06 22:29:01 -08:00
led_tables.h	Change include guards in quantum/ to pragma once (#11239)	2020-12-26 15:53:12 +11:00
main.c	Refactor vusb to protocol use pre/post task (#14944)	2024-03-14 21:45:12 +11:00
matrix.c	Update atomic GPIO macros in keyboard custom matrix (#23796)	2024-07-13 18:41:05 +10:00
matrix.h	core: allow locking the matrix state (#18852)	2023-02-13 03:38:36 +11:00
matrix_common.c	quantum: remove direct quantum.h includes (#21507)	2023-07-16 23:42:56 +10:00
modifiers.h	Relocate various modifier defines (#18638)	2023-03-10 18:27:29 -08:00
mousekey.c	Enhance overlapping mouse keys control (#23341)	2024-08-19 03:18:28 +01:00
mousekey.h	Enhance overlapping mouse keys control (#23341)	2024-08-19 03:18:28 +01:00
os_detection.c	Community modules (#24848)	2025-02-26 22:25:41 +11:00
os_detection.h	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
pointing_device_internal.h	[Core] Introduce pointing device specific debug messages (#17663)	2022-08-29 19:16:49 +02:00
programmable_button.c	Programmable Button API refactor and improve docs (#18641)	2022-10-15 14:33:24 +11:00
programmable_button.h	Update Doxygen comments for some headers (#20194)	2023-03-22 14:32:49 +11:00
quantum.c	Implement connection keycode logic (#25176)	2025-04-21 22:27:56 +01:00
quantum.h	[Core] get_keycode_string(): function to format keycodes as strings, for more readable debug logging. (#24787)	2025-03-19 20:45:56 +01:00
quantum_keycodes.h	[Feature] Add keycode PDF(layer) to set the default layer in EEPROM (#24630)	2024-11-23 10:09:34 +00:00
quantum_keycodes_legacy.h	Add new connection keycodes for Bluetooth, 2.4GHz. (#24251)	2024-08-27 10:52:23 +10:00
raw_hid.h	Raw HID: documentation improvements (#21596)	2023-07-25 09:20:41 +10:00
repeat_key.c	Normalise mouse keycodes (#23975)	2024-07-03 18:35:54 +10:00
repeat_key.h	quantum: remove direct quantum.h includes (#21507)	2023-07-16 23:42:56 +10:00
ring_buffer.h	Fix quantum ring_buffer for ChibiOS (#19683)	2023-01-28 21:07:51 +00:00
secure.c	Use a macro to compute the size of arrays at compile time (#18044)	2022-08-30 10:20:04 +02:00
secure.h	Update Doxygen comments for some headers (#20194)	2023-03-22 14:32:49 +11:00
steno_keycodes.h	Remove requirement for keymap_steno.h include in keymaps (#22423)	2023-11-12 18:25:46 +11:00
sync_timer.c	Format code according to conventions (#16322)	2022-02-12 18:29:31 +00:00
sync_timer.h	Relocate protocol files within tmk_core/common/ (#14972)	2021-10-28 22:31:59 +01:00
tri_layer.c	[Core] Tri Layer Keys (#19795)	2023-02-12 10:23:07 +11:00
tri_layer.h	[Core] Tri Layer Keys (#19795)	2023-02-12 10:23:07 +11:00
util.h	[Core] quantum: util: add bit and bitmask helpers (#24229)	2024-10-12 18:48:00 +02:00
variable_trace.c	clang-format changes	2019-08-30 15:01:52 -07:00
variable_trace.h	Change include guards in quantum/ to pragma once (#11239)	2020-12-26 15:53:12 +11:00
via.c	Allow for disabling EEPROM subsystem entirely. (#25173)	2025-04-19 20:20:00 +01:00
via.h	Non-volatile memory data repository pattern (#24356)	2025-03-21 23:38:34 +11:00
virtser.h	Relocate protocol files within tmk_core/common/ (#14972)	2021-10-28 22:31:59 +01:00
wpm.c	[Bug] Fix compilation issue with WPM (#18965)	2022-11-05 19:05:01 +00:00
wpm.h	Reduce includes for wpm header (#18949)	2022-11-04 00:50:59 +00:00