ahoneybun/qmk_firmware
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Ignore the Layer Lock key in Repeat Key and Caps Word. (#25171)

Browse source
This commit is contained in:
Pascal Getreuer 2025-04-19 11:57:00 -07:00 • committed by GitHub
parent 88453acc6a
commit ea85ace4a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 91 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tests/repeat_key/test.mk
View file

@ -16,3 +16,4 @@
REPEAT_KEY_ENABLE = yes
AUTO_SHIFT_ENABLE = yes
LAYER_LOCK_ENABLE = yes

33
tests/repeat_key/test_repeat_key.cpp
View file

@ -751,4 +751,37 @@ TEST_F(RepeatKey, RepeatKeyInvoke) {
testing::Mock::VerifyAndClearExpectations(&driver);
}
// Check that mods and Layer Lock are not remembered.
TEST_F(RepeatKey, IgnoredKeys) {
TestDriver driver;
KeymapKey regular_key(0, 0, 0, KC_A);
KeymapKey key_repeat(0, 1, 0, QK_REP);
KeymapKey key_lsft(0, 2, 0, KC_LSFT);
KeymapKey key_lctl(0, 3, 0, KC_LCTL);
KeymapKey key_llck(0, 4, 0, QK_LAYER_LOCK);
set_keymap({regular_key, key_repeat, key_lsft, key_lctl, key_llck});
// Allow any number of empty reports.
EXPECT_EMPTY_REPORT(driver).Times(AnyNumber());
{
InSequence seq;
EXPECT_REPORT(driver, (KC_A));
EXPECT_REPORT(driver, (KC_LSFT));
EXPECT_REPORT(driver, (KC_LCTL));
EXPECT_REPORT(driver, (KC_A));
EXPECT_REPORT(driver, (KC_A));
}
tap_key(regular_key); // Taps the KC_A key.
// Tap Shift, Ctrl, and Layer Lock keys, which should not be remembered.
tap_keys(key_lsft, key_lctl, key_llck);
EXPECT_KEYCODE_EQ(get_last_keycode(), KC_A);
// Tapping the Repeat Key should still reproduce KC_A.
tap_keys(key_repeat, key_repeat);
testing::Mock::VerifyAndClearExpectations(&driver);
}
} // namespace