Fixed inverted LED logic in the USB2AX board LED driver (thanks to Nicolas Saugnier).
This commit is contained in:
		
							parent
							
								
									e875d7cf9f
								
							
						
					
					
						commit
						bd6123e2c1
					
				
					 2 changed files with 17 additions and 16 deletions
				
			
		| 
						 | 
				
			
			@ -54,13 +54,13 @@
 | 
			
		|||
 *  <b>USB2AX</b>:
 | 
			
		||||
 *  <table>
 | 
			
		||||
 *    <tr><th>Name</th><th>Color</th><th>Info</th><th>Active Level</th><th>Port Pin</th></tr>
 | 
			
		||||
 *    <tr><td>LEDS_LED1</td><td>Green</td><td>General Indicator</td><td>Low</td><td>PORTC.6</td></tr>
 | 
			
		||||
 *    <tr><td>LEDS_LED1</td><td>Green</td><td>General Indicator</td><td>High</td><td>PORTC.6</td></tr>
 | 
			
		||||
 *  </table>
 | 
			
		||||
 *
 | 
			
		||||
 *  <b>USB2AX_V3</b>:
 | 
			
		||||
 *  <table>
 | 
			
		||||
 *    <tr><th>Name</th><th>Color</th><th>Info</th><th>Active Level</th><th>Port Pin</th></tr>
 | 
			
		||||
 *    <tr><td>LEDS_LED1</td><td>Green</td><td>General Indicator</td><td>Low</td><td>PORTD.1</td></tr>
 | 
			
		||||
 *    <tr><td>LEDS_LED1</td><td>Green</td><td>General Indicator</td><td>High</td><td>PORTD.1</td></tr>
 | 
			
		||||
 *  </table>
 | 
			
		||||
 *
 | 
			
		||||
 *  @{
 | 
			
		||||
| 
						 | 
				
			
			@ -108,11 +108,11 @@
 | 
			
		|||
			static inline void LEDs_Init(void)
 | 
			
		||||
			{
 | 
			
		||||
				#if (BOARD == BOARD_USB2AX)
 | 
			
		||||
				DDRC  |= LEDS_ALL_LEDS;
 | 
			
		||||
				PORTC |= LEDS_ALL_LEDS;				
 | 
			
		||||
				DDRC  |=  LEDS_ALL_LEDS;
 | 
			
		||||
				PORTC &= ~LEDS_ALL_LEDS;				
 | 
			
		||||
				#else
 | 
			
		||||
				DDRD  |= LEDS_ALL_LEDS;
 | 
			
		||||
				PORTD |= LEDS_ALL_LEDS;				
 | 
			
		||||
				DDRD  |=  LEDS_ALL_LEDS;
 | 
			
		||||
				PORTD &= ~LEDS_ALL_LEDS;				
 | 
			
		||||
				#endif				
 | 
			
		||||
			}
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -130,27 +130,27 @@
 | 
			
		|||
			static inline void LEDs_TurnOnLEDs(const uint8_t LEDMask)
 | 
			
		||||
			{
 | 
			
		||||
				#if (BOARD == BOARD_USB2AX)
 | 
			
		||||
				PORTC &= ~LEDMask;				
 | 
			
		||||
				PORTC |= LEDMask;				
 | 
			
		||||
				#else
 | 
			
		||||
				PORTD &= ~LEDMask;
 | 
			
		||||
				PORTD |= LEDMask;
 | 
			
		||||
				#endif
 | 
			
		||||
			}
 | 
			
		||||
 | 
			
		||||
			static inline void LEDs_TurnOffLEDs(const uint8_t LEDMask)
 | 
			
		||||
			{
 | 
			
		||||
				#if (BOARD == BOARD_USB2AX)
 | 
			
		||||
				PORTC |= LEDMask;
 | 
			
		||||
				PORTC &= ~LEDMask;
 | 
			
		||||
				#else
 | 
			
		||||
				PORTD |= LEDMask;
 | 
			
		||||
				PORTD &= ~LEDMask;
 | 
			
		||||
				#endif
 | 
			
		||||
			}
 | 
			
		||||
 | 
			
		||||
			static inline void LEDs_SetAllLEDs(const uint8_t LEDMask)
 | 
			
		||||
			{
 | 
			
		||||
				#if (BOARD == BOARD_USB2AX)
 | 
			
		||||
				PORTC = ((PORTC | LEDS_ALL_LEDS) & ~LEDMask);				
 | 
			
		||||
				PORTC = ((PORTC & ~LEDS_ALL_LEDS) | LEDMask);				
 | 
			
		||||
				#else
 | 
			
		||||
				PORTD = ((PORTD | LEDS_ALL_LEDS) & ~LEDMask);
 | 
			
		||||
				PORTD = ((PORTD & ~LEDS_ALL_LEDS) | LEDMask);
 | 
			
		||||
				#endif
 | 
			
		||||
			}
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -158,9 +158,9 @@
 | 
			
		|||
			                                   const uint8_t ActiveMask)
 | 
			
		||||
			{
 | 
			
		||||
				#if (BOARD == BOARD_USB2AX)
 | 
			
		||||
				PORTC = ((PORTC | LEDMask) & ~ActiveMask);				
 | 
			
		||||
				PORTC = ((PORTC & ~LEDMask) | ActiveMask);				
 | 
			
		||||
				#else
 | 
			
		||||
				PORTD = ((PORTD | LEDMask) & ~ActiveMask);
 | 
			
		||||
				PORTD = ((PORTD & ~LEDMask) | ActiveMask);
 | 
			
		||||
				#endif
 | 
			
		||||
			}
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -177,9 +177,9 @@
 | 
			
		|||
			static inline uint8_t LEDs_GetLEDs(void)
 | 
			
		||||
			{
 | 
			
		||||
				#if (BOARD == BOARD_USB2AX)
 | 
			
		||||
				return (~PORTC & LEDS_ALL_LEDS);				
 | 
			
		||||
				return (PORTC & LEDS_ALL_LEDS);				
 | 
			
		||||
				#else
 | 
			
		||||
				return (~PORTD & LEDS_ALL_LEDS);
 | 
			
		||||
				return (PORTD & LEDS_ALL_LEDS);
 | 
			
		||||
				#endif
 | 
			
		||||
			}
 | 
			
		||||
		#endif
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue