ahoneybun/qmk_firmware
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix helix/rev2 not working properly when using split_common. (#16512)

Browse source 
When helix/rev2 was using split_common, it didn't work properly and I couldn't type on the right hand side.

The cause is that the following code, added in 0.16.0 to `quantum/keyboard.c`, does not include `quantum/split_common/split_util.h` but instead includes `keyboards/helix/rev2/split_util.h`. Therefore, `split_pre_init()/split_post_init()` in `quantum/split_common/split_util.c` was not called.

```c
  #ifdef SPLIT_KEYBOARD
  #    include "split_util.h"
  #endif
```
This commit is contained in:
Takeshi ISHII 2022-03-04 05:23:49 +09:00 • committed by GitHub
parent ae2c77c827
commit 4a66bdf294
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

21
keyboards/helix/rev2/custom/split_util.h Normal file
View file

@ -0,0 +1,21 @@
#pragma once
#ifdef SPLIT_KEYBOARD
# error This is helix local split_util.h.
# error This header file is used only when SPLIT_KEYBOARD=no.
#endif
#include <stdbool.h>
#include "eeconfig.h"
#define SLAVE_I2C_ADDRESS 0x32
extern volatile bool isLeftHand;
// slave version of matix scan, defined in matrix.c
void matrix_slave_scan(void);
void split_keyboard_setup(void);
bool is_helix_master(void);
void matrix_master_OLED_init (void);