ahoneybun/qmk_firmware
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed RNDISEthernet demos crashing when calculating checksums for Ethernet/TCP packets of more than ~500 bytes due to an overflow in the checksum calculation loop (thanks to Kevin Malec).

Browse source 
Removed string Attributes from the Service Discovery Protocol code to minimise the potential points of failure while the base code is being debugged.
This commit is contained in:
Dean Camera 2010-05-25 06:14:37 +00:00
parent 8f3d4e69c3
commit 4a13a5484a
8 changed files with 18 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Demos/Device/LowLevel/RNDISEthernet/Lib/TCP.c
View file

@ -605,7 +605,7 @@ static uint16_t TCP_Checksum16(void* TCPHeaderOutStart, IP_Address_t SourceAddre
Checksum += SwapEndian_16(PROTOCOL_TCP);
Checksum += SwapEndian_16(TCPOutSize);
for (uint8_t CurrWord = 0; CurrWord < (TCPOutSize >> 1); CurrWord++)
for (uint16_t CurrWord = 0; CurrWord < (TCPOutSize >> 1); CurrWord++)
Checksum += ((uint16_t*)TCPHeaderOutStart)[CurrWord];
if (TCPOutSize & 0x01)