Changed the signature of the CALLBACK_USB_GetDescriptor() callback function so that the descriptor pointer is const, to remove the need for extra casting inside the callback (thanks to Jonathan Kollasch).
This commit is contained in:
		
							parent
							
								
									ed8ad18f26
								
							
						
					
					
						commit
						092f82e06f
					
				
					 88 changed files with 460 additions and 409 deletions
				
			
		| 
						 | 
				
			
			@ -201,48 +201,48 @@ USB_Descriptor_String_t PROGMEM ProductString =
 | 
			
		|||
 */
 | 
			
		||||
uint16_t CALLBACK_USB_GetDescriptor(const uint16_t wValue,
 | 
			
		||||
                                    const uint8_t wIndex,
 | 
			
		||||
                                    void** const DescriptorAddress)
 | 
			
		||||
                                    const void** const DescriptorAddress)
 | 
			
		||||
{
 | 
			
		||||
	const uint8_t  DescriptorType   = (wValue >> 8);
 | 
			
		||||
	const uint8_t  DescriptorNumber = (wValue & 0xFF);
 | 
			
		||||
 | 
			
		||||
	void*    Address = NULL;
 | 
			
		||||
	uint16_t Size    = NO_DESCRIPTOR;
 | 
			
		||||
	const void* Address = NULL;
 | 
			
		||||
	uint16_t    Size    = NO_DESCRIPTOR;
 | 
			
		||||
 | 
			
		||||
	switch (DescriptorType)
 | 
			
		||||
	{
 | 
			
		||||
		case DTYPE_Device:
 | 
			
		||||
			Address = (void*)&DeviceDescriptor;
 | 
			
		||||
			Address = &DeviceDescriptor;
 | 
			
		||||
			Size    = sizeof(USB_Descriptor_Device_t);
 | 
			
		||||
			break;
 | 
			
		||||
		case DTYPE_Configuration: 
 | 
			
		||||
			Address = (void*)&ConfigurationDescriptor;
 | 
			
		||||
			Address = &ConfigurationDescriptor;
 | 
			
		||||
			Size    = sizeof(USB_Descriptor_Configuration_t);
 | 
			
		||||
			break;
 | 
			
		||||
		case DTYPE_String: 
 | 
			
		||||
			switch (DescriptorNumber)
 | 
			
		||||
			{
 | 
			
		||||
				case 0x00: 
 | 
			
		||||
					Address = (void*)&LanguageString;
 | 
			
		||||
					Address = &LanguageString;
 | 
			
		||||
					Size    = pgm_read_byte(&LanguageString.Header.Size);
 | 
			
		||||
					break;
 | 
			
		||||
				case 0x01: 
 | 
			
		||||
					Address = (void*)&ManufacturerString;
 | 
			
		||||
					Address = &ManufacturerString;
 | 
			
		||||
					Size    = pgm_read_byte(&ManufacturerString.Header.Size);
 | 
			
		||||
					break;
 | 
			
		||||
				case 0x02: 
 | 
			
		||||
					Address = (void*)&ProductString;
 | 
			
		||||
					Address = &ProductString;
 | 
			
		||||
					Size    = pgm_read_byte(&ProductString.Header.Size);
 | 
			
		||||
					break;
 | 
			
		||||
			}
 | 
			
		||||
			
 | 
			
		||||
			break;
 | 
			
		||||
		case DTYPE_HID: 
 | 
			
		||||
			Address = (void*)&ConfigurationDescriptor.HID_JoystickHID;
 | 
			
		||||
			Address = &ConfigurationDescriptor.HID_JoystickHID;
 | 
			
		||||
			Size    = sizeof(USB_Descriptor_HID_t);
 | 
			
		||||
			break;
 | 
			
		||||
		case DTYPE_Report: 
 | 
			
		||||
			Address = (void*)&JoystickReport;
 | 
			
		||||
			Address = &JoystickReport;
 | 
			
		||||
			Size    = sizeof(JoystickReport);
 | 
			
		||||
			break;
 | 
			
		||||
	}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -89,6 +89,7 @@
 | 
			
		|||
	/* Function Prototypes: */
 | 
			
		||||
		uint16_t CALLBACK_USB_GetDescriptor(const uint16_t wValue,
 | 
			
		||||
		                                    const uint8_t wIndex,
 | 
			
		||||
		                                    void** const DescriptorAddress) ATTR_WARN_UNUSED_RESULT ATTR_NON_NULL_PTR_ARG(3);
 | 
			
		||||
		                                    const void** const DescriptorAddress)
 | 
			
		||||
		                                    ATTR_WARN_UNUSED_RESULT ATTR_NON_NULL_PTR_ARG(3);
 | 
			
		||||
 | 
			
		||||
#endif
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue